Remove clippy warnings #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary "use omaha" Remove 'static for const strings. Use Some(h) instead of map(). Remove map(f) on an Option value where f is a closure that returns unit type (). Deref would be done by auto-deref. Remove unneeded return. Use if instead of match in case of equility checks. Remove redundant pattern matching, use is_some(). Use From<Hash<T>> for Vec<u8> instead of Into<Vec<u8>> for Hash<T>. Remove unnecessary Ok and question mark
dongsupark
force-pushed
the
dongsu/clippy-202311
branch
from
59afc78
to
bccd6f2
Compare
pothos
approved these changes
Nov 29, 2023
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 7, 2023
Update ue-rs to 0.1.0-r4, 2023-12-05. Pulls in flatcar/ue-rs#26, flatcar/ue-rs#29, flatcar/ue-rs#30, flatcar/ue-rs#36, flatcar/ue-rs#37, flatcar/ue-rs#39, flatcar/ue-rs#40.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issues reported by
cargo clippy.use omaha.'staticfor const strings.Some(h)instead of map().map(f)on an Option value where f is a closure that returns unit type ().return.is_some().From<Hash<T>> for Vec<u8>instead ofInto<Vec<u8>> for Hash<T>.Okand question mark.Note: issues in
vendor/hard-xml*are not touched.Fixes #32