Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatcar-postinst: In addition to SHA1, also check SHA256 hash for OEMs #26

Merged
merged 2 commits into from
Sep 28, 2023
Merged

flatcar-postinst: In addition to SHA1, also check SHA256 hash for OEMs #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
381da58
flatcar-postinst: In addition to SHA1, also check SHA256 hash for OEMs
pothos Sep 27, 2023
d7d9d52
flatcar-postinst: Note for tweaking download logic later
pothos Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions flatcar-postinst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,19 +71,28 @@ sysext_download() {
entries=$(grep -m 1 -o "<package name=\"${name}\"[^>]*" "${from}")
url="${base}/${name}"
size=$(echo "${entries}" | grep -o 'size="[0-9]*' | cut -d '"' -f 2)
hash=$(echo "${entries}" | grep -o -P 'hash="[^"]*' | cut -d '"' -f 2) # openssl dgst -binary -sha1 < "$PAYLOAD" | base64
hash=$(echo "${entries}" | { grep -o -P 'hash="[^"]*' || true ; } | cut -d '"' -f 2) # openssl dgst -binary -sha1 < "$PAYLOAD" | base64
hash_sha256=$(echo "${entries}" | { grep -o -P 'hash_sha256="[^"]*' || true ; } | cut -d '"' -f 2) # sha256sum -b "$PAYLOAD" | cut -d " " -f 1
fi
rm -f "${target}.tmp"
curl -fsSL --retry-delay 1 --retry 60 --retry-connrefused --retry-max-time 60 --connect-timeout 20 -o "${target}.tmp" "${url}"
if [ "${size}" != "" ] && [ "${hash}" != "" ]; then
if [ "${base}" != "" ]; then
if [ "$(stat --printf='%s' "${target}.tmp")" != "${size}" ]; then
echo "Size mismatch for ${name}" >&2
return 1 # jump to ret=
fi
if [ "$(openssl dgst -binary -sha1 < "${target}.tmp" | base64)" != "${hash}" ]; then
if [ "${hash}" = "" ] && [ "${hash_sha256}" = "" ]; then
echo "At least one hash is expected, found none in Omaha package for ${name}" >&2
return 1 # jump to ret=
fi
if [ "${hash}" != "" ] && [ "$(openssl dgst -binary -sha1 < "${target}.tmp" | base64)" != "${hash}" ]; then
echo "Hash mismatch for ${name}" >&2
return 1 # jump to ret=
fi
if [ "${hash_sha256}" != "" ] && [ "$(sha256sum -b "${target}.tmp" | cut -d " " -f 1)" != "${hash_sha256}" ]; then
echo "Hash SHA256 mismatch for ${name}" >&2
return 1 # jump to ret=
fi
fi
# Using "${INSTALL_MNT}" here is ok because it was verified first by update-engine
PROTOPATH="${INSTALL_MNT}"/share/update_engine/ "${INSTALL_MNT}"/share/update_engine/decode_payload /usr/share/update_engine/update-payload-key.pub.pem "${target}.tmp" "${target}"
Expand Down Expand Up @@ -118,7 +127,8 @@ if [ "${OEMID}" != "" ] && { [ -e "${INSTALL_MNT}/share/flatcar/oems/${OEMID}" ]
fi
done
# Note that in the case of VERSION=NEXT_VERSION we will replace the running sysext and maybe it's better
# to do so than not because it allows to recover from a corrupted file (where the corruption happened on disk)
# to do so than not because it allows to recover from a corrupted file (where the corruption happened on disk).
# However, as soon as update-engine would already download the payload, we should skip the overwriting.
SUCCESS=false
# Preferred is to download from the location given by the Omaha response
# which only works with a new update-engine client that creates "full-response",
Expand Down