This repository was archived by the owner on Mar 24, 2023. It is now read-only.
Simplify Neo contract to store id instead of address #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the Neo contract to use an id instead of an address to store the
paid out amount
(I call ittea
). Also, the message to be signed is now the concatenation ofid
+total earned amount
(previouslyaddress
+total earned amount
).I haven't worked on invoke part on the golang side here. I can take a look sometime, or maybe @faragos or @a-lesi could take a look at this and integrate it in this PR.
Last but not least, you can check the updated contract code here and I've also updated all integration tests to verify that the update actually works as expected.
@tbocek @gsmachado