Skip to content
This repository was archived by the owner on Mar 24, 2023. It is now read-only.

Simplify Neo contract to store id instead of address #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mialbu
Copy link
Contributor

@mialbu mialbu commented Jan 21, 2023

I've updated the Neo contract to use an id instead of an address to store the paid out amount (I call it tea). Also, the message to be signed is now the concatenation of id + total earned amount (previously address + total earned amount).

I haven't worked on invoke part on the golang side here. I can take a look sometime, or maybe @faragos or @a-lesi could take a look at this and integrate it in this PR.

Last but not least, you can check the updated contract code here and I've also updated all integration tests to verify that the update actually works as expected.

@tbocek @gsmachado

@faragos
Copy link
Contributor

faragos commented Jan 27, 2023

@mialbu long time no see 🙂
TBH I'm a little bit out-of-the-loop to exactly do the change. I looked at your change shortly. I see the batchPayout now has 3 parameters. I'm not sure how to get the ownerId. If you want we can do a session on your side. Because I have a new PC and I don't have any tooling anymore.

@tbocek
Copy link
Contributor

tbocek commented Feb 5, 2023

Thanks! I'll take a look at it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants