Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exceptions: Add xdg config access to com.github.GradienceTeam.Gradience. #243

Merged
merged 3 commits into from
Jan 1, 2024

Conversation

Etaash-mathamsetty
Copy link
Contributor

@Etaash-mathamsetty Etaash-mathamsetty commented Dec 28, 2023

seems like this app needs this suddenly needs this new lint rule, was it recently added?

@Etaash-mathamsetty Etaash-mathamsetty changed the title exceptions: Add finish-args-unnecessary-xdg-config-access to com.gith… exceptions: Add xdg config access to com.github.GradienceTeam.Gradience. Dec 28, 2023
@hfiguiere
Copy link
Contributor

the lint was fixed recently so it didn't get triggered before.

@bbhtt
Copy link
Contributor

bbhtt commented Jan 1, 2024

LGTM, it checks relative to XDG_DATA_HOME first https://github.com/GradienceTeam/Gradience/blob/c878099d15a5488c5d6b4bc6dbb1a283a3032da0/gradience/backend/globals.py#L26 and the app is made to mess around gtk themes.

@bbhtt bbhtt merged commit 325cea0 into flathub-infra:master Jan 1, 2024
2 checks passed
@bbhtt bbhtt added the exceptions Request to add exceptions label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exceptions Request to add exceptions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants