Align setup according to https://github.com/leerob/next-self-host/blob/main/deploy.sh#L139 #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razzeee
force-pushed
the
nginx-change
branch
from
b423a1b to
bddf6ca
Compare
razzeee
commented
Dec 1, 2024
| @@ -108,6 +108,15 @@ http { | |||
|
|
|||
| location / { | |||
| proxy_pass http://frontend:3000/; | |||
| proxy_http_version 1.1; | |||
There was a problem hiding this comment.
@barthalion I'm not too sure if we want these changes
There was a problem hiding this comment.
sounds like something websockets related which we don't use?
There was a problem hiding this comment.
Yes, not sure if there's any harm in having it anyway, but I guess using nginx defaults would be fine - even if they might be very conservative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.