-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frequent crashes (SEGV) in libappindicator.so.1.0.0 #30
Comments
@tvannahl Does this still occur with the latest version? |
I'll try it out by deactivating the Appindicator extension for the next week. |
I haven't had any problems until now. It appears to be fixed, I'll reopen if the problem resurfaces. |
Found it - again!
|
Happening to me as well.
|
Version 0.0.9. Same issue: kernel.log:
Using Linux Mint 19.1 Any workaround? Could we use the deb file instead of Flatpack? ... |
A workaround under Gnome is to install the KStatusNotifierItem/AppIndicator Support. I haven't had any issues whilst running this extension. |
This is not Flatpak specific. My Discord (AUR package) also crashes regularly when I'm in a voice call. And installing the AppIndicator extension did not help. |
I have the same issue with libappindicator3.so in xfce running under Xubuntu. But I found a workaround. I removed the Item, "Notification Area" from the xfce4-panel preferences and I'm now using the "Status Notifier Plugin" Item instead. It works in pretty much the same way but doesn't crash Discord. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There are only two options: Remove appindicator so nobody gets a tray icon, or deal with occasional crashes. We can't fix Discord. |
Also experiencing this (both with the flatpak and the deb, so this issue should be closed) since May. Wrote a script to auto-restart Discord whenever it crashes. Annoying for my friends to hear the login/logout sound though. Sad that Discord ignores their Linux client. |
Still seeing this:
This is with the |
Please stop bumping this issue. The situation is that Discord is causing a crash in libappindicator and it has nothing to do with this package. So unless you work at Discord or are willing to make a custom patch to libappindicator to workaround this then the comment is not helpful. |
This comment has been minimized.
This comment has been minimized.
Absolutely nothing about this is related to Flatpak, so this isn't the
place for backtraces.
IMO this issue should just be locked with a summary message at the very
end, since there's nothing else to really be done here.
…On Sun, Feb 9, 2020, 10:55 AM Sam Voss ***@***.***> wrote:
I like how you mention
or are willing to make a custom patch to libappindicator to workaround
this then the comment is not helpful.
And yet you guys are deleting comments of people putting backtraces in
here for somebody who may take on patching libappindicator.
Actually pathetic.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#30?email_source=notifications&email_token=AAM4YSN3N4LYAGYTEYKZ46TRCAYQZA5CNFSM4E7LRNP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGR2MA#issuecomment-583867696>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM4YSJBE6GOAGN25KXKB7LRCAYQZANCNFSM4E7LRNPQ>
.
|
The reason I leave it opened is because Discord doesn't give a damn and will never fix it, and libappindicator is a dead unmaintained library. So patching here is doable and realistically the only solution. But I guess I will have to lock it if people want to make drama. |
@TingPing No need to 'fix Discord', this is a bug in libappindicator. Installed Discord for the first time yesterday and ran into this. Thanks to @tvannahl 's solid bug report and @TingPing not closing the issue, I was able to find this issue itself, then find and fix the bug in libappindicator. I have reported the bug with patch upstream here: https://bugs.launchpad.net/archlinux/+source/libappindicator/+bug/1867996 Below please find the patch should you wish to apply it before Ubuntu/Canonical gets their act together (which might be a long time) and your distro pulls the updated source from them (an even longer time).
I don't use flatpaks, but my understanding is you can bundle libraries. If you can ship a patched version of libappindicator in the flatpak, it'll solve the issue for everyone using it well before the fix propagates to all the distros. |
Ah nice, wouldn't this just need to be applied to the Electron baseapp?
…On Wed, Mar 18, 2020, 5:17 PM Paul G ***@***.***> wrote:
@TingPing <https://github.com/TingPing> No need to 'fix Discord', this is
a bug in libappindicator. Installed Discord for the first time yesterday
and ran into this. Thanks to @tvannahl <https://github.com/tvannahl> 's
solid bug report and @TingPing <https://github.com/TingPing> not closing
the issue, I was able to find this issue itself, then find and fix the bug
in libappindicator.
I have reported the bug with patch upstream here:
https://bugs.launchpad.net/archlinux/+source/libappindicator/+bug/1867996
Below please find the patch should you wish to apply it before
Ubuntu/Canonical gets their act together (which might be a long time) and
your distro pulls the updated source from them (an even longer time).
--- libappindicator/src/app-indicator.c 2020-03-17 18:14:09.254862070 -0400
+++ wrk/src/app-indicator.c 2020-03-17 21:05:31.009065383 -0400
@@ -2137,7 +2137,7 @@
g_free (self->priv->absolute_icon_theme_path);
self->priv->absolute_icon_theme_path = get_real_theme_path (self);
- g_signal_emit (self, signals[NEW_ICON_THEME_PATH], 0, self->priv->icon_theme_path, TRUE);
+ g_signal_emit (self, signals[NEW_ICON_THEME_PATH], 0, self->priv->icon_theme_path);
if (self->priv->dbus_registration != 0 && self->priv->connection != NULL) {
const gchar *theme_path = self->priv->absolute_icon_theme_path ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM4YSIT4KQKS2IKD6FWDO3RIFB7XANCNFSM4E7LRNPQ>
.
|
Patch added, builds in progress. |
Build published, let me know if its solved. |
@TingPing It turns out there are actually multiple problems of this kind in libappindicator. Please apply the (more extensive) last patch attached to this bug: |
I already applied the newer patch. :) |
I needed to apply the latest patch, from 21 March 2020, in order to stop seeing these crashes. You might want to try that one too @TingPing since it wasn't yet included in the bug report listed above. |
Well that patch doesn't cleanly apply so that will have to be looked into... |
It is a one line change so I did it manually. Thought it was just me doing something silly with |
@gigawhitlocks If you make one to cleanly apply here I'd appreciate it: flathub/shared-modules@7181045 I actually didn't look into it at all as I'm a bit busy. |
@gigawhitlocks Are you/were you able to push the clean patches to the repo? Once you do we can finally put this issue to rest, and I can't get it to work myself. |
All patches landed. Try next update. |
I still have the issue, how can I tell if I have the correct version? |
Discord does frequently crash on my system (Fedora 28, Gnome 3.28 Desktop, Flatpak 0.11.7).
Currently I was unable to trigger the bug on purpose or filter out a specific context on which it happens. But it does happen a lot on my system:
The full backtrace including
com.discordapp.Discord.Debug
does look like the following:For me this looks like a bug relevant for io.atom.electron.BaseApp. I tried for hours to gather more information, but I am not a C/C++ developer. Furthermore I only found out that libappindicator is quite a mess someone really should take over. The bugs did occur without having "application indicator" support active in my desktop, I will run everything with active "application indicator" on my gnome-shell but for now that is fresh — so I don't know if it does affect the bug.
The text was updated successfully, but these errors were encountered: