Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime 43 #9

Merged
merged 6 commits into from
May 16, 2023
Merged

Runtime 43 #9

merged 6 commits into from
May 16, 2023

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Sep 29, 2022

Trying runtime 43...

The python manifest is now generated with flatpak-pip-generator, that updates the dependencies and individual module requirements and cleans up the indentation mess.

Closes #10

@flathubbot
Copy link

Started test build 113090

@bbhtt
Copy link
Contributor Author

bbhtt commented Sep 29, 2022

Started test build 113090

  INFO: unifing config_fc, config, build_clib, build_ext, build commands --fcompiler options
  Traceback (most recent call last):
    File "/usr/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
      main()
    File "/usr/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/usr/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 164, in prepare_metadata_for_build_wheel
      return hook(metadata_directory, config_settings)
    File "/usr/lib/python3.10/site-packages/setuptools/build_meta.py", line 377, in prepare_metadata_for_build_wheel
      self.run_setup()
    File "/usr/lib/python3.10/site-packages/setuptools/build_meta.py", line 482, in run_setup
      super(_BuildMetaLegacyBackend,
    File "/usr/lib/python3.10/site-packages/setuptools/build_meta.py", line 335, in run_setup
      exec(code, locals())
    File "<string>", line 494, in <module>
    File "<string>", line 486, in setup_package
    File "/usr/lib/python3.10/site-packages/setuptools/__init__.py", line 87, in setup
      return distutils.core.setup(**attrs)
    File "/usr/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 185, in setup
      return run_commands(dist)
    File "/usr/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
      dist.run_commands()
    File "/usr/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 973, in run_commands
      self.run_command(cmd)
    File "/usr/lib/python3.10/site-packages/setuptools/dist.py", line 1217, in run_command
      super().run_command(command)
    File "/usr/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 992, in run_command
      cmd_obj.run()
    File "/usr/lib/python3.10/site-packages/setuptools/command/dist_info.py", line 96, in run
      self.egg_info.run()
    File "/tmp/pip-install-_g3rg1g1/numpy_77ea1b650ee54eb69e4996ca9a1b66f6/numpy/distutils/command/egg_info.py", line 25, in run
      _egg_info.run(self)
    File "/usr/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 308, in run
      self.find_sources()
    File "/usr/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 316, in find_sources
      mm.run()
    File "/usr/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 560, in run
      self.add_defaults()
    File "/usr/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 597, in add_defaults
      sdist.add_defaults(self)
    File "/usr/lib/python3.10/site-packages/setuptools/command/sdist.py", line 107, in add_defaults
      self._add_defaults_build_sub_commands()
    File "/usr/lib/python3.10/site-packages/setuptools/command/sdist.py", line 127, in _add_defaults_build_sub_commands
      self.filelist.extend(chain.from_iterable(files))
    File "/usr/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 503, in extend
      self.files.extend(filter(self._safe_path, paths))
    File "/usr/lib/python3.10/site-packages/setuptools/command/sdist.py", line 126, in <genexpr>
      files = (c.get_source_files() for c in cmds if hasattr(c, "get_source_files"))
    File "/usr/lib/python3.10/site-packages/setuptools/command/sdist.py", line 125, in <genexpr>
      cmds = (self.get_finalized_command(c) for c in missing_cmds)
    File "/usr/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 306, in get_finalized_command
      cmd_obj.ensure_finalized()
    File "/usr/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 109, in ensure_finalized
      self.finalize_options()
    File "/tmp/pip-install-_g3rg1g1/numpy_77ea1b650ee54eb69e4996ca9a1b66f6/numpy/distutils/command/config_compiler.py", line 69, in finalize_options
      v = getattr(c, a)
    File "/usr/lib/python3.10/site-packages/Cython/Distutils/old_build_ext.py", line 157, in __getattr__
      return _build_ext.build_ext.__getattr__(self, name)
    File "/usr/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 105, in __getattr__
      raise AttributeError(attr)
  AttributeError: fcompiler. Did you mean: 'compiler'?
  error: subprocess-exited-with-error

pypa/setuptools#3549

I don't think it is possible to make it use an earlier version of setuptools if I include it in the manifest (it skips the build because it finds setuptools from the runtime first) and it doesn't sound a good idea to have two different versions of setuptools in parallel.

Making this a draft until above issue is resolved.

@bbhtt bbhtt marked this pull request as draft September 29, 2022 13:05
@flathubbot
Copy link

Build 113090 failed

bbhtt added a commit to bbhtt/com.endlessm.photos that referenced this pull request Sep 30, 2022
Workaround for incompatibility with setuptools>=64.x
flathub#9 (comment)
@flathubbot
Copy link

Started test build 113240

@flathubbot
Copy link

Started test build 113244

@flathubbot
Copy link

Started test build 113246

@flathubbot
Copy link

Build 113240 failed

@flathubbot
Copy link

Started test build 113250

@flathubbot
Copy link

Build 113244 failed

@flathubbot
Copy link

Build 113246 failed

@bbhtt
Copy link
Contributor Author

bbhtt commented Sep 30, 2022

Build 113246 failed

ninja-python is trying to download the ninja source and failing: scikit-build/ninja-python-distributions#127

I'll pin scipy to an earlier version not depending on mesonpy.

@flathubbot
Copy link

Build 113250 failed

@flathubbot
Copy link

Started test build 113255

@flathubbot
Copy link

Started test build 113256

@flathubbot
Copy link

Build 113255 failed

@flathubbot
Copy link

Build 113256 failed

@flathubbot
Copy link

Started test build 113456

@flathubbot
Copy link

Started test build 113462

@bbhtt
Copy link
Contributor Author

bbhtt commented Oct 1, 2022

dbus-pyton is also pinned to 1.2.18 since it also depends on mesonpy thus ninja-python

- Build numpy with setuptools 59.2.0 in isolation

  Workaround for incompatibility with setuptools>=64.x
  flathub#9 (comment)

- Pin scipy to 1.8.1 and build it in isolation and pin dbus-python to
  1.2.18

  Newer versions of both depend on mesonpy which in turn depends on
  ninja-python that tries to download the ninja tarball
@flathubbot
Copy link

Build 113462 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/111064/com.endlessm.photos.flatpakref

@bbhtt bbhtt marked this pull request as ready for review October 1, 2022 16:08
@flathubbot
Copy link

Build 113456 failed

@bbhtt
Copy link
Contributor Author

bbhtt commented Oct 1, 2022

Build 113462 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/111064/com.endlessm.photos.flatpakref

endlessm/eos-photos#330

@flathubbot
Copy link

Started test build 113671

@flathubbot
Copy link

Build 113671 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/111278/com.endlessm.photos.flatpakref

@vwbusguy vwbusguy mentioned this pull request May 9, 2023
@flathubbot
Copy link

Started test build 40824

@flathubbot
Copy link

Build 40824 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/23465/com.endlessm.photos.flatpakref

@bbhtt
Copy link
Contributor Author

bbhtt commented May 13, 2023

Works now. cc @wjt @GeorgesStavracas

This includes the patches removed in this commit.

endlessm/eos-photos#331
@flathubbot
Copy link

Started test build 41367

@wjt
Copy link
Member

wjt commented May 16, 2023

Thanks for this! I updated this with your patches plus a couple more from endlessm/eos-photos#331.

@flathubbot
Copy link

Build 41367 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/24007/com.endlessm.photos.flatpakref

@wjt wjt merged commit b4452ca into flathub:master May 16, 2023
@wjt wjt mentioned this pull request May 16, 2023
@bbhtt bbhtt deleted the runtime-43 branch May 16, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported runtime (42)
3 participants