Only share X11 display with the app if Wayland is unavailable #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started test build 44787 |
Closed
|
Build 44787 successful |
AsciiWolf
reviewed
Apr 26, 2021
smcv
force-pushed
the
wip/no-x11-if-wayland
branch
from
4583541 to
a81e37c
Compare
|
Started test build 47520 |
|
Build 47520 successful |
smcv
force-pushed
the
wip/no-x11-if-wayland
branch
from
a81e37c to
d3e99fa
Compare
|
Started test build 47526 |
|
Build 47526 successful |
This improves the isolation between the app's sandbox and the host
system when running in a Wayland-capable environment, such as
GNOME Shell in its default Wayland mode or KDE Plasma Desktop in its
non-default Wayland mode (both tested on Debian 11).
The UI shell uses Qt, which was given Wayland support in the previous
commit.
The actual streaming client uses SDL, which defaults to X11 but will
use Wayland if no X11 display is available.
To test:
Xephyr :2 &
DISPLAY=:2 flatpak run com.valvesoftware.SteamLink//master
You should see that the Steam Link app (both the shell and the actual
streaming client) continues to run full-screen rather than being confined
to the Xephyr display, indicating that both parts are using Wayland
rather than X11.
Signed-off-by: Simon McVittie <smcv@collabora.com>
smcv
force-pushed
the
wip/no-x11-if-wayland
branch
from
d3e99fa to
955251c
Compare
|
Started test build 59138 |
|
Build 59138 successful |
|
Now that GNOME Software is producing increasingly scary warnings for X11 apps (see screenshot), I think it's worth pushing ahead with this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the isolation between the app's sandbox and the host
system when running in a Wayland-capable environment, such as
GNOME Shell in its default Wayland mode (tested on Debian 11) or
KDE Plasma Desktop in its non-default Wayland mode (not tested).
The UI shell uses Qt, which was given Wayland support in the previous
commit.
The actual streaming client uses SDL, which defaults to X11 but will
use Wayland if no X11 display is available.
To test:
You should see that the Steam Link app (both the shell and the actual
streaming client) continues to run full-screen rather than being confined
to the Xephyr display, indicating that both parts are using Wayland
rather than X11.
Based on #15. We should probably get a beta release out with #15 merged before landing this, but this is where I'd like to get to eventually.
@lhindir, as with #15, when the flathub bot has built a test package for this, it would be great if you could try it in your Wayland environment and let us know how well it works.