Make UnityLauncherAPI work #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started test build 103991 |
|
Build 103991 failed |
|
bot, build |
|
Queued test build for dev.vencord.Vesktop. |
|
Started test build 106439 |
|
Build 106439 successful |
Vendicated
reviewed
Mar 12, 2024
| - --talk-name=com.canonical.Unity | ||
| # Electron checks if it running on Unity/KDE before using the UnityLauncherAPI, so we need to pretend we are on KDE to make it work on other desktops | ||
| - --env=XDG_CURRENT_SESSION=KDE | ||
| - --env=XDG_CURRENT_DESKTOP=KDE |
There was a problem hiding this comment.
pretending to be a different desktop environment seems wrong. why is this necessary?
There was a problem hiding this comment.
Electron does check the current desktop for some reason. If we want to make this work outside KDE, we need to pretend we are on KDE.
|
yeah like i said this is a bad idea. for example this completely breaks opening links because xdg-open tries to use konqueror to open it. electron 32 will remove this kde check, so we should just wait for that! thanks for the contribution anyway
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Vencord/Vesktop#298