-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
element.sh: Add Electron flags for improved UX under Wayland #325
Conversation
If a Wayland session is detected, add the following Electron flags for an improved user experience: ``` --ozone-platform-hint=auto --enable-features=WaylandWindowDecorations,WebRTCPipeWireCapturer ``` For Wayland sessions, this will: - enable scaling of the application window - add decorations (i.e. the close window button) to the application window - enable screensharing of the application window
Always add the `--enable-features=WebRTCPipeWireCapturer` Electron flag in order to enable screensharing in non-Wayland sessions on systems running Pipewire, too.
Started test build 18579 |
Build 18579 successful
|
Some important things to note. I understand that previously, the idea was to not deviate from upstream element. The problem we face with electron is that everyone tries to pass the burden of doing the change upstream. When the change is made here, it could fix the issue for the userbase that is directly affected by that issue. Either way, many thanks for maintaining the flatpak version of element, and of cource Lorbus for this PR. |
cc @SISheogorath for comment |
It looks reasonable to me, though it will change the window classes and therefore probably cause any user-defined window settings to be reset. |
I'm still not a big fan of doing this differently than upstream. However, I guess we end up with a chicken-egg problem, as in: The defaults won't change because no one uses the new stuff, and the new stuff won't be used due to defaults not changing. Let's be brave and go forward with it. Let's go! |
No description provided.