Add org.freedesktop.Flatpak permission #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started test build 103701 |
|
bot, build |
|
Queued test build for io.freetubeapp.FreeTube. |
|
Started test build 103703 |
|
Build 103703 successful |
|
Build 103701 failed |
Freeube can play videos using external players. This is need to launch the external players from the sandbox by calling flatpak-spawn --host. This isn't very ideal as it allows to run arbitrary commands from inside the sandbox.
|
Started test build 4648 |
|
Build 4648 failed |
This is failing due to the linter, an exception must be requested. |
|
cc @PrestonN |
|
I'm closing this flatpak spawn is a huge access and doesn't make sense to me when a) Freetube can play the videos by itself B) External player is optional and there are too many to support C) Maybe it'd be better to include at least MPV in this flatpak The alternative is to wait for a portal solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
This isn't very ideal as it allows to run arbitrary commands from inside the sandbox. But there's no other solution I can think of since Freetube doesn't download the video, it only passes the link to the external player.
Tested with: