bump node version to 16 #21

muelli · 2022-04-01T06:24:21Z

No description provided.

flathubbot · 2022-04-01T06:24:34Z

flathubbot · 2022-04-01T07:33:23Z

with flatpak-node-generator as of c278045d7cc73437945b3dfb919fc7aea5d43cb5 python3 -m flatpak_node_generator yarn ~/vcs/lossless-cut/yarn.lock --output ~/vcs/no.mifi.losslesscut/generated-sources.json This also requires a change in the build definition to include the yarn configuration.

flathubbot · 2023-03-02T13:33:47Z

Started test build 25868

Yarn is built in now, isn't it?

flathubbot · 2023-03-02T13:40:09Z

Build 25868 failed

…node16

flathubbot · 2023-03-02T13:40:47Z

Started test build 25870

the new generator produces a setup file that makes it work. Inspired by https://github.com/flathub/net.cozic.joplin_desktop/blob/8aad869adfc541c07a9284aad33aad59165b1a33/net.cozic.joplin_desktop.yml#L74

flathubbot · 2023-03-02T13:42:05Z

Started test build 25873

flathubbot · 2023-03-02T13:50:05Z

Build 25873 failed

flathubbot · 2023-03-02T13:50:17Z

Build 25870 failed

flathubbot · 2023-03-02T14:41:32Z

Started test build 25901

flathubbot · 2023-03-02T14:50:07Z

Build 25901 failed

weird. Somehow, the yarn.lock file in the lossless-cut repository got changed. Now it corresponds to the 3.52.0 tag. dd1b44f2d3d645056df78175b421aff414b103e2

flathubbot · 2023-03-02T15:08:13Z

Started test build 25912

flathubbot · 2023-03-02T15:12:00Z

Started test build 25915

flathubbot · 2023-03-02T15:15:16Z

Build 25912 failed

flathubbot · 2023-03-02T15:20:05Z

Build 25915 failed

catsout · 2023-03-02T15:23:58Z

flatpak/flatpak-builder-tools#173 (comment)

…node16

flathubbot · 2023-03-02T15:28:27Z

Started test build 25922

flathubbot · 2023-03-02T15:35:05Z

Build 25922 failed

I wonder why this is necessary, though, because we're calling pack-linux and there is a "prepack-linux" script defined. Let's see whether this works.

flathubbot · 2023-03-02T15:43:29Z

Started test build 25930

flathubbot · 2023-03-02T15:52:10Z

Build 25930 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8589/no.mifi.losslesscut.flatpakref

muelli · 2023-03-02T16:04:18Z

The app works. Thanks @catsout.

But there's a big ASAR file, despite electron-builder complaining about the lack of ASAR:

Running: yarn run pack-linux dir
FB: Running 'flatpak build --die-with-parent --env=FLATPAK_BUILDER_BUILDDIR=/run/build/lossless-cut --nofilesystem=host:reset --filesystem=/srv/buildbot/worker/build-x86_64-2/build/.flatpak-builder/build/lossless-cut-1 --bind-mount=/run/build/lossless-cut=/srv/buildbot/worker/build-x86_64-2/build/.flatpak-builder/build/lossless-cut-1 --build-dir=/run/build/lossless-cut --bind-mount=/run/ccache=/srv/buildbot/worker/build-x86_64-2/build/.flatpak-builder/ccache --unshare=network --env=SOURCE_DATE_EPOCH=1677771815 '--env=CFLAGS=-O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer ' '--env=CXXFLAGS=-O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer ' '--env=LDFLAGS=-L/app/lib -Wl,-z,relro,-z,now -Wl,--as-needed ' --env=XDG_CACHE_HOME=/run/build/lossless-cut/flatpak-node/cache --env=npm_config_nodedir=/usr/lib/sdk/node18 --env=NPM_CONFIG_LOGLEVEL=info --env=CCACHE_DIR=/run/ccache/disabled --env=PATH=/app/bin:/usr/bin:/usr/lib/sdk/node18/bin --env=LD_LIBRARY_PATH=/app/lib --env=PKG_CONFIG_PATH=/app/lib/pkgconfig:/app/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig --env=FLATPAK_BUILDER_N_JOBS=64 /srv/buildbot/worker/build-x86_64-2/build/.flatpak-builder/rofiles/rofiles-G97wXT /bin/sh -c 'yarn run pack-linux dir'' on host
  • electron-builder  version=23.6.0 os=5.15.0-47-generic
  • loaded configuration  file=package.json ("build" field)
  • writing effective config  file=dist/builder-effective-config.yaml
  • packaging       platform=linux arch=x64 electron=23.1.0 appOutDir=dist/linux-unpacked
  • asar usage is disabled — this is strongly not recommended  solution=enable asar and use asarUnpack to unpack files that must be externally available
  • asar usage is disabled — this is strongly not recommended  solution=enable asar and use asarUnpack to unpack files that must be externally available
FB: host_command_exited_cb 1419254 0

I wonder how to make it not produce an ASAR file.

@catsout why does this work for you?
https://github.com/flathub/net.cozic.joplin_desktop/blob/8aad869adfc541c07a9284aad33aad59165b1a33/net.cozic.joplin_desktop.yml#L82
The package.json does not define a "dist" target.

catsout · 2023-03-02T16:07:48Z

https://github.com/laurent22/joplin/blob/v2.10.8/packages/app-desktop/package.json#L8

muelli · 2023-03-02T16:10:58Z

hm. Thanks. It's gone from here, though: https://github.com/laurent22/joplin/blob/dev/package.json

What happens to the arguments? Are they simply appended to the target? i.e. yarn run electronRebuild && npx electron-builder --x64 --config.asar=false --linux --dir?

Taken from https://github.com/flathub/net.cozic.joplin_desktop/blob/8aad869adfc541c07a9284aad33aad59165b1a33/net.cozic.joplin_desktop.yml#L82

flathubbot · 2023-03-02T16:13:42Z

Started test build 25934

flathubbot · 2023-03-02T16:23:06Z

Build 25934 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8593/no.mifi.losslesscut.flatpakref

muelli · 2023-03-02T16:28:06Z

looks better now.

I think the modern generators take care of those.

flathubbot · 2023-03-02T16:31:22Z

Started test build 25944

we call the packing with the --config.asar=false flag which makes it work better.

flathubbot · 2023-03-02T16:32:43Z

Started test build 25945

the file is automatically generated now.

flathubbot · 2023-03-02T16:33:55Z

Started test build 25946

flathubbot · 2023-03-02T16:42:37Z

Build 25944 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8603/no.mifi.losslesscut.flatpakref

flathubbot · 2023-03-02T16:43:00Z

Build 25946 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8605/no.mifi.losslesscut.flatpakref

flathubbot · 2023-03-02T16:43:45Z

Build 25945 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8604/no.mifi.losslesscut.flatpakref

bump node version to 16

e408e38

muelli added 3 commits March 1, 2023 15:31

update to 3.52.0

91cc5f1

Merge branch 'master' into node16

31bf285

update node to 18

4934573

Yarn is built in now, isn't it?

muelli added 2 commits March 2, 2023 14:40

Merge branch 'node16' of github.com:flathub/no.mifi.losslesscut into …

06cb862

…node16

Merge branch '3.52.0' into node16

3de47f8

only run yarn install

96b7eca

the new generator produces a setup file that makes it work. Inspired by https://github.com/flathub/net.cozic.joplin_desktop/blob/8aad869adfc541c07a9284aad33aad59165b1a33/net.cozic.joplin_desktop.yml#L74

muelli mentioned this pull request Mar 2, 2023

node: Add yarn2 support flatpak/flatpak-builder-tools#252

Open

1 task

Merge branch 'master' into node16

d1ae369

re-generate sources

3d6cd59

weird. Somehow, the yarn.lock file in the lossless-cut repository got changed. Now it corresponds to the 3.52.0 tag. dd1b44f2d3d645056df78175b421aff414b103e2

Merge branch 'master' into node16

5dc024a

muelli added 2 commits March 2, 2023 16:27

remove caching directive hoping to make it find electron

e3664af

flatpak/flatpak-builder-tools#173 (comment)

Merge branch 'node16' of github.com:flathub/no.mifi.losslesscut into …

6dd4174

…node16

build explicitly

8d6742d

I wonder why this is necessary, though, because we're calling pack-linux and there is a "prepack-linux" script defined. Let's see whether this works.

muelli mentioned this pull request Mar 2, 2023

Update LosslessCut version #39

Closed

try to build without ASAR

463e023

Taken from https://github.com/flathub/net.cozic.joplin_desktop/blob/8aad869adfc541c07a9284aad33aad59165b1a33/net.cozic.joplin_desktop.yml#L82

remove chromedriver

4464da4

I think the modern generators take care of those.

remove no-asar patch

62eedb8

we call the packing with the --config.asar=false flag which makes it work better.

remove stale appdata reference

ad6db1b

the file is automatically generated now.

muelli merged commit 2d1b26e into master Mar 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump node version to 16 #21

bump node version to 16 #21

muelli commented Apr 1, 2022

flathubbot commented Apr 1, 2022

flathubbot commented Apr 1, 2022

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

catsout commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

muelli commented Mar 2, 2023

catsout commented Mar 2, 2023

muelli commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

muelli commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

bump node version to 16 #21

bump node version to 16 #21

Conversation

muelli commented Apr 1, 2022

flathubbot commented Apr 1, 2022

flathubbot commented Apr 1, 2022

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

catsout commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

muelli commented Mar 2, 2023

catsout commented Mar 2, 2023

muelli commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

muelli commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023

flathubbot commented Mar 2, 2023