Add flatpak Discord Rich Presence support

[Parnassius]

No description provided.

[flathubbot]

Started test build 3240

[flathubbot]

Build 3240 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/3096/org.DolphinEmu.dolphin-emu.flatpakref

[cpba]

Thank you for taking the time to do this.

Could you elaborate a bit on what this feature does and how to test it?

The discord website describes it as a source of viral advertising for games, is it intended to show other people on discord that you are playing games on dolphin? Does it do anything else?

[Parnassius]

Yes, it allows to show other people what game you are playing on dolphin. Upstream dolphin already has this feature, this pull request only adds support for discord installed as a flatpak. See flathub/com.discordapp.Discord#29 and https://github.com/flathub/com.discordapp.Discord/wiki/Rich-Precense-(discord-rpc) for more informations.

I tested both a local build and the build provided by the bot, and it appears to be working. To test it yourself you should install discord from flathub, create an account if you don't already have one, and then run dolphin.

If you just created a new account probably the easiest way to test is to create a new server (green + on the left side of the window, you only have to provide a name).
On your profile (on the right side) should then appear something like this:

[TingPing]

Desktop file needs updated.

[flathubbot]

Queued test build for org.DolphinEmu.dolphin-emu.

[flathubbot]

Started test build 3296

[flathubbot]

Build 3296 failed

[flathubbot]

Started test build 3350

[flathubbot]

Build 3350 failed

[flathubbot]

Started test build 3488

[flathubbot]

Build 3488 failed

[cpba]

@Parnassius your builds are failing because of the new flathub appdata requirements, I've been meaning to fix it for a while but I haven't gotten around to doing it yet.

[cpba]

bot, build

[flathubbot]

Queued test build for org.DolphinEmu.dolphin-emu.

[flathubbot]

Started test build 3502

[flathubbot]

Build 3502 failed

[TingPing]

Looks fine. @cpba can fix the appdata then we'll rebase this.

[cpba]

I'm pretty sure I fixed it yesterday before bed, you can rebase.

…

On Fri, 17 May 2019, 09:57 Patrick, ***@***.***> wrote: Looks fine. @cpba <https://github.com/cpba> can fix the appdata then we'll rebase this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#39?email_source=notifications&email_token=ACZPHZGZSPHI3NVMO6OTU3LPVZQONA5CNFSM4HMGGW72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVUBIRA#issuecomment-493360196>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACZPHZG3W3QA5UDSLL2DZHLPVZQONANCNFSM4HMGGW7Q> .

[gasinvein]

Before this is merged, I hope to change discord-rpc socket path from xdg-run/discord/ipc-0 to xdg-run/app/com.discordapp.Discord/discord-ipc-0, see flathub/com.discordapp.Discord#68.

[flathubbot]

Started test build 3776

[flathubbot]

Build 3776 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/3604/org.DolphinEmu.dolphin-emu.flatpakref

[cpba]

I understand that this pull request is waiting on flathub/com.discordapp.Discord#68 before it can be merged?

[gasinvein]

The change required after that PR would be trivial, so it's probably not a blocker. Just be aware of its state.

[cpba]

My concern is that if I merge this now, anybody who starts using it will see it break when they update discord. Would this be the case?

…

On Wed, 22 May 2019, 00:31 Filippe LeMarchand, ***@***.***> wrote: The change required after that PR would be trivial, so it's probably not a blocker. Just be aware of its state. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#39?email_source=notifications&email_token=ACZPHZAAJR3S4LA6UHMYZA3PWRZ37A5CNFSM4HMGGW72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV5L27I#issuecomment-494583165>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACZPHZE23OEDIC3LNA3BUNTPWRZ37ANCNFSM4HMGGW7Q> .

[gasinvein]

Yes.

[TingPing]

Merged the Discord change so we can update this.

[flathubbot]

Started test build 4045

[flathubbot]

Build 4045 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/3861/org.DolphinEmu.dolphin-emu.flatpakref

[TingPing]

This has a merge conflict and needs to be rebased (feel free to squash).

[flathubbot]

Started test build 4052

[flathubbot]

Build 4052 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/3869/org.DolphinEmu.dolphin-emu.flatpakref

[flathubbot]

Started test build 4053

[flathubbot]

Build 4053 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/3870/org.DolphinEmu.dolphin-emu.flatpakref

[Parnassius]

Should be ready now