Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt for current Frescobaldi packaging and test LilyPond autoinstallation #37

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeanas
Copy link
Collaborator

@jeanas jeanas commented Aug 4, 2023

@fedelibre This is my attempt at fixing the issues in #36.

@flathubbot
Copy link
Contributor

Started test build 56944

@jeanas
Copy link
Collaborator Author

jeanas commented Aug 4, 2023

Uh, I forgot tox's dependencies.

dependencies = [
  "cachetools>=5.3.1",
  "chardet>=5.1",
  "colorama>=0.4.6",
  "filelock>=3.12.2",
  'importlib-metadata>=6.7; python_version < "3.8"',
  "packaging>=23.1",
  "platformdirs>=3.8",
  "pluggy>=1.2",
  "pyproject-api>=1.5.2",
  'tomli>=2.0.1; python_version < "3.11"',
  'typing-extensions>=4.6.3; python_version < "3.8"',
  "virtualenv>=20.23.1",
]

@flathubbot
Copy link
Contributor

Build 56944 failed

@flathubbot
Copy link
Contributor

Started test build 56953

@flathubbot
Copy link
Contributor

Build 56953 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/39575/org.frescobaldi.Frescobaldi.flatpakref

@jeanas
Copy link
Collaborator Author

jeanas commented Aug 4, 2023

Good!

I'm in a place with limited Internet access right now, so I'll let other people test the build.

@flathubbot
Copy link
Contributor

Started test build 57025

@flathubbot
Copy link
Contributor

Build 57025 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/39648/org.frescobaldi.Frescobaldi.flatpakref

@fedelibre
Copy link
Collaborator

I made a quick test and it works great!

@jeanas
Copy link
Collaborator Author

jeanas commented Aug 4, 2023

Good, thank you!

@jeanas
Copy link
Collaborator Author

jeanas commented Aug 4, 2023

What should we do with this PR now? Most of this will also be useful for the 3.4 release. Should I just close it and let you adapt it when we release 3.4?

@fedelibre
Copy link
Collaborator

fedelibre commented Aug 5, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants