Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ibus-gtk2, exiv2, gexiv2, poppler and 2 more modules #338

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

flathubbot
Copy link
Contributor

@flathubbot flathubbot commented Aug 9, 2024

Update by Bruno (17/08/2024)


ibus-gtk2: Update ibus-1.5.29.tar.gz to 1.5.30
exiv2: Update v0.28.2.tar.gz to 0.28.3
gexiv2: Update gexiv2-0.14.2.tar.xz to 0.14.3
poppler: Update poppler-24.04.0.tar.xz to 24.08.0
ghostscript: Update ghostscript-10.03.0.tar.gz to 10.03.1
openblas: Update v0.3.26.tar.gz to 0.3.28

🤖 This pull request was automatically generated by flathub-infra/flatpak-external-data-checker. Please open an issue if you have any questions or complaints. 🤖

@flathubbot
Copy link
Contributor Author

Started test build 139279

@flathubbot
Copy link
Contributor Author

Build 139279 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/122312/org.gimp.GIMP.flatpakref

@brunvonlope
Copy link
Collaborator

brunvonlope commented Aug 10, 2024

Finally, openblas was updated with the fix to NO_CBLAS=1 that got broken in 0.3.27

I will do some tests and, if positive, I will merge this tomorrow

@brunvonlope
Copy link
Collaborator

bot, build

@flathubbot
Copy link
Contributor Author

Queued test build for org.gimp.GIMP.

@flathubbot
Copy link
Contributor Author

Started test build 139699

@flathubbot
Copy link
Contributor Author

Build 139699 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/122736/org.gimp.GIMP.flatpakref

@brunvonlope
Copy link
Collaborator

exiv2, gexiv2, poppler, ghostscript and openblas are working.

libheif NOT working. Can't export to any libheif format (avif, heic...).

ibus-gtk2 have no idea.

@Jehan
Copy link
Collaborator

Jehan commented Aug 13, 2024

ibus-gtk2 have no idea.

IBus is for Input Engine Methods, such as writing in languages like Korean, Japanese, Chinese, or other languages which require an IME.

So I guess testing Ibus-gtk would be something like this:

  • install an IME on your system, e.g. "IbusHangul";
  • activate it and set it to Hangul Mode;
  • make sure it works by testing in other random software (e.g. a text editor), by typing random stuff;
  • you should start seeing Hangul (Korean characters) such as: "안녕";
  • now do the same stuff in (type random stuff on your keyboard) in some field in GIMP.

Result: observe that GIMP also properly receives the Korean characters.

If it doesn't work, then something is wrong.

@Jehan
Copy link
Collaborator

Jehan commented Aug 13, 2024

P.S.: and I just tested your branch. Ibus doesn't work.

Also the terminal is full of such warnings:

(gimp-2.10:2): Gtk-WARNING **: 12:18:10.854: /app/lib/gtk-2.0/2.10.0/immodules/im-ibus.so: undefined symbol: ibus_input_context_set_post_process_key_event

(gimp-2.10:2): Gtk-WARNING **: 12:18:10.854: Loading IM context type 'ibus' failed

So there is definitely something broken here.

This being said:

  1. This also doesn't work with the released stable branch of the flatpak. So it's likely not this update which has a problem. There was already a problem.
  2. The beta branch works fine. No weird warnings in terminal and I can write fine with an IME.

For info, my main text field where I test writing with an IME is inside the canvas, in a text layer, with text tool active, because I implemented IME support myself there and that's in fact the main place where one would want to write in any given language in GIMP! Though this should work in any text field (e.g. layer names, etc.).

@brunvonlope
Copy link
Collaborator

@Jehan Thanks for testing the im module!


your branch

Are you talking to the robot, right?! haha


About the warnings, we are aware of them in https://gitlab.gnome.org/GNOME/gimp/-/issues/11469 and https://gitlab.gnome.org/GNOME/gimp/-/issues/11589 I was hoping that the new release would fix it but wasn't the case 🫤

@Jehan
Copy link
Collaborator

Jehan commented Aug 13, 2024

Are you talking to the robot, right?! haha

LOL. Didn't pay attention that it was a patch created by the robot. 😋

ibus-gtk2: Update ibus-1.5.29.tar.gz to 1.5.30
exiv2: Update v0.28.2.tar.gz to 0.28.3
gexiv2: Update gexiv2-0.14.2.tar.xz to 0.14.3
poppler: Update poppler-24.04.0.tar.xz to 24.08.0
ghostscript: Update ghostscript-10.03.0.tar.gz to 10.03.1
openblas: Update v0.3.26.tar.gz to 0.3.28
@brunvonlope brunvonlope changed the title Update ibus-gtk2, exiv2, gexiv2, poppler and 3 more modules Update ibus-gtk2, exiv2, gexiv2, poppler and 2 more modules Aug 17, 2024
@flathubbot
Copy link
Contributor Author

Started test build 140826

@flathubbot
Copy link
Contributor Author

Build 140826 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/123874/org.gimp.GIMP.flatpakref

@brunvonlope
Copy link
Collaborator

Merging (without libheif update) as per constructive testing above.

@brunvonlope brunvonlope merged commit 71c0b5c into master Aug 17, 2024
1 check passed
@brunvonlope brunvonlope deleted the update-d338093 branch August 17, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants