Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system-provided ICU libraries #195

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

j20001970
Copy link
Contributor

Building Godot with freetype, libpng, zlib, graphite, harfbuzz as system-provided while leaving icu4c as built-in leads to editor crash when loading GDExtension libraries that uses std::call_once in static initialization.

Please refer to godotengine/godot#91401 for details.

While godotengine/godot#99883 is not merged yet at the time of writing, unofficial Godot builds could change build configuration to use system-provided icu4c libraries, so that it can open minimal reproduction project like https://github.com/j20001970/godot_static_call_once_crash successfully like official build.

@flathubbot
Copy link
Contributor

Started test build 165483

@flathubbot
Copy link
Contributor

Build 165483 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/148564/org.godotengine.Godot.flatpakref

@Calinou Calinou added the bug Something isn't working label Dec 1, 2024
Copy link
Collaborator

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@j20001970 j20001970 marked this pull request as draft December 12, 2024 07:54
@j20001970
Copy link
Contributor Author

j20001970 commented Dec 12, 2024

Sorry for converting this to a draft abruptly, I later found a bug when building the engine with system-provided ICU library. Will convert back again if this get addressed upstream.

@flathubbot
Copy link
Contributor

Started test build 167511

@flathubbot
Copy link
Contributor

Build 167511 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/150608/org.godotengine.Godot.flatpakref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants