Add pygame 2 #247
Add pygame 2 #247
Conversation
|
Could you please give some examples of apps that make use of this module as bundled here? |
It isn't clear which modules are unnecessary as same modules were bundled with SDL, looking around does help for sure but that won't be clear to someone contributing for the first time. |
|
The person who adds shared-module is expected to maintain it for the foreseeable future. They should know the build details and what dependency is necessary. |
Agreed. |
|
If it takes less than 30 minutes to build, maintenance overhead of a BaseApp is not worth it. |
I was thinking a more generic BaseApp, that just includes some common game libraries (pygame, newer SDL2, wine, gamemode). This would also solve #221. |
|
First you need to define a clear usecase, are these apps using wine for example? We already have a base app with wine. |
| ], | ||
| "buildsystem": "simple", | ||
| "build-commands": [ | ||
| "pip3 install --ignore-installed --no-deps --prefix=/app ." |
There was a problem hiding this comment.
You should run setup.py cython, to recythonise the sources before installing. Upstream c sources might not match with the python C api available in the runtime or app. The c api time to time introduces changes leading to build failures like #201 and the python version is a moving target as it is in shared-modules and will get included in manifests that have different python versions.
https://www.pygame.org/wiki/GettingStarted#Compilation
Some of the .c files are generated by Cython from .pyx files. Running "setup.py cython" will update them.
|
You are missing the addition to |
Since pygame 2 is based on SDL2, its dependencies are also added.