Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixing immobilienscout crawler #5

Merged
merged 3 commits into from
May 21, 2020
Merged

Conversation

mordax7
Copy link

@mordax7 mordax7 commented May 21, 2020

Fixing the problem when user did not specify pagenumbe in the immobilienscout URL, making it loop over the same page over and over again. This caused, getting the same flat on Telegram several times.
Also fixed the rooms attribute, which was sending too much content, had to trim it.
Some small refactoring

@mordax7 mordax7 added the enhancement New feature or request label May 21, 2020
@mordax7 mordax7 requested a review from codders May 21, 2020 13:48
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #5 into master will increase coverage by 0.24%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   48.92%   49.16%   +0.24%     
==========================================
  Files           7        7              
  Lines         419      421       +2     
  Branches       49       49              
==========================================
+ Hits          205      207       +2     
  Misses        206      206              
  Partials        8        8              
Impacted Files Coverage Δ
flathunter/crawl_immobilienscout.py 52.94% <57.14%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66d019...8ba6825. Read the comment docs.

Copy link

@codders codders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants