cuFINUFFT does not install correctly in a windows environment, possibly using some linux library

[Zhe0301]

The error code is as follows:
utils.h(13,10): error C1083: Cannot open include file: 'sys/time.h': No such file or directory

[ahbarnett]

Dear Wangzhe, Could you go back to release 2.3.0 and let us know if that works? Thanks, Alex

…

On Tue, Nov 12, 2024 at 9:00 PM WangzheZhou ***@***.***> wrote: The error code is as follows: utils.h(13,10): error C1083: Cannot open include file: 'sys/time.h': No such file or directory — Reply to this email directly, view it on GitHub <#589>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNZRST3W73XG3ZSOXIY6VT2AKXB7AVCNFSM6AAAAABRVLRJMCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2TGOBYGAYDKMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- *-------------------------------------------------------------------~^`^~._.~' |\ Alex Barnett Center for Computational Mathematics, Flatiron Institute | \ http://users.flatironinstitute.org/~ahb 646-876-5942

[lu1and10]

'sys/time.h' is a unix header.

We changed to use #include <chrono> in cpu code so that timer in cpu code uses chrono function calls,

finufft/src/utils.cpp

Line 53 in 33d80c3

std::uint64_t now = std::chrono::duration_cast<std::chrono::microseconds>(

While gpu code still uses gettimeofday

finufft/src/cuda/utils.cpp

Line 28 in 33d80c3

void CNTime::start() { gettimeofday(&initial, 0); }

Need to reuse cpu utils.cpp in gpu code and remove the gpu side unix header 'sys/time.h' as we did in cpu code

[Zhe0301]

Thank you for your attention to this issue. According to my tests, both versions 2.3.1 and 2.3.0 have this problem. The problem occurs when cuFINNUFFT is installed with pip, i.e., the command: 'pip install cufinufft'.

…

________________________________ 发件人: Alex Barnett ***@***.***> 发送时间: 2024年11月13日 10:49 收件人: flatironinstitute/finufft ***@***.***> 抄送: WangzheZhou ***@***.***>; Author ***@***.***> 主题: Re: [flatironinstitute/finufft] cuFINUFFT does not install correctly in a windows environment, possibly using some linux library (Issue #589) Dear Wangzhe, Could you go back to release 2.3.0 and let us know if that works? Thanks, Alex

On Tue, Nov 12, 2024 at 9:00 PM WangzheZhou ***@***.***> wrote: The error code is as follows: utils.h(13,10): error C1083: Cannot open include file: 'sys/time.h': No such file or directory — Reply to this email directly, view it on GitHub <#589>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNZRST3W73XG3ZSOXIY6VT2AKXB7AVCNFSM6AAAAABRVLRJMCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2TGOBYGAYDKMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- *-------------------------------------------------------------------~^`^~._.~' |\ Alex Barnett Center for Computational Mathematics, Flatiron Institute | \ http://users.flatironinstitute.org/~ahb 646-876-5942 — Reply to this email directly, view it on GitHub<#589 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AP6Y2ZZLSGJDOST7XJ3NMP32AK43DAVCNFSM6AAAAABRVLRJMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZSGI2TQOBYGM>. You are receiving this because you authored the thread.

[lu1and10]

Thank you for your attention to this issue. According to my tests, both versions 2.3.1 and 2.3.0 have this problem. The problem occurs when cuFINNUFFT is installed with pip, i.e., the command: 'pip install cufinufft'.

Yes, the unix header 'sys/time.h' is always there on gpu code.
If pip install builds from sources which on windows is the case, it will complain about the unix header on windows. I guess we don't have a gpu window python wheel uploaded to pypi yet.

[DiamonDinoia]

I believe we could finish #577 and merge it. That will do.

I would like to remind that cufinufft is not officially supported on windows yet. It is on the TODO list. We were waiting for the CPU refactor to merge common functionalities in a common library and take care of these issues.