Using density to determine upsampfact, deferring to setpts when auto #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ahbarnett
reviewed
Dec 1, 2025
include/finufft/fft.h
Outdated
| std::complex<float> *ptr, int sign, int options, int nthreads) { | ||
| uint64_t nf = 1; | ||
| for (auto i : dims) nf *= i; | ||
| #ifdef _OPENMP |
Collaborator
There was a problem hiding this comment.
Does this fix some unrelated issue?
Collaborator
Author
There was a problem hiding this comment.
It is needed because we allow fft replan in this PR. We were not allowing before (I think). If we change upsampfact and call makeplan again we have a memory leak. But we do not allow multiple call to makeplan. WIth this PR setpts can replan so we need this.
ahbarnett
reviewed
Dec 1, 2025
DiamonDinoia
force-pushed
the
feature/hint-nj-density
branch
3 times, most recently
from
9c29d30 to
c92eb36
Compare
DiamonDinoia
force-pushed
the
feature/hint-nj-density
branch
from
c92eb36 to
a52cae1
Compare
DiamonDinoia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upsampfact choice is deferred to setpts if the user uses auto upsampfact. This way density can be used to choose a faster value.