Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #210

Merged
merged 256 commits into from
Aug 14, 2024
Merged

Development #210

merged 256 commits into from
Aug 14, 2024

Conversation

BalzaniEdoardo
Copy link
Collaborator

Merge development into main. Main changes:

  1. New API for: Regularizer, BaseRegressor and GLM. Regularizers are now stateless, and all the hyperparameters for the regularizers and solvers can be set at BaseRegressor initialization. See Refactoring regularizer and solver  #183 for more info.
  2. Updated contributing guide and developers notes. See update contributing guide #198
  3. Improved API for TransformerBasis. All basis attribute are accessible directly from the transformer basis. This facilitates cross-validation and inspection. See Update TransformerBasis and Basis to work with scikit-learn pipelining and CV #169.
  4. Improved Calcium imaging tutorial. See update to calcium imaging demo #159.

Thanks to @clewis7, @bagibence and, @EricThomson for the great contributions! 🚀 🚀 🚀

BalzaniEdoardo and others added 28 commits August 10, 2024 10:54
Co-authored-by: William F. Broderick <billbrod@gmail.com>
Co-authored-by: William F. Broderick <billbrod@gmail.com>
Co-authored-by: William F. Broderick <billbrod@gmail.com>
Co-authored-by: William F. Broderick <billbrod@gmail.com>
Co-authored-by: William F. Broderick <billbrod@gmail.com>
Co-authored-by: William F. Broderick <billbrod@gmail.com>
Co-authored-by: William F. Broderick <billbrod@gmail.com>
Co-authored-by: William F. Broderick <billbrod@gmail.com>
Update `TransformerBasis` and `Basis` to work with scikit-learn pipelining and CV
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 97.68638% with 9 lines in your changes missing coverage. Please review.

Project coverage is 97.30%. Comparing base (23433ce) to head (b5f0808).
Report is 1 commits behind head on main.

Files Patch % Lines
src/nemos/base_regressor.py 96.35% 5 Missing ⚠️
src/nemos/basis.py 96.61% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   97.23%   97.30%   +0.06%     
==========================================
  Files          15       18       +3     
  Lines        1484     1669     +185     
==========================================
+ Hits         1443     1624     +181     
- Misses         41       45       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalzaniEdoardo BalzaniEdoardo merged commit f62fcf8 into main Aug 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants