-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip: Add support for pyproject.toml #332
base: master
Are you sure you want to change the base?
Conversation
@@ -158,6 +169,16 @@ if opts.requirements_file: | |||
except FileNotFoundError: | |||
pass | |||
|
|||
elif opts.pyproject_file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it should error if both --requirements-file
and --pyproject-file
are given.
@@ -28,6 +28,8 @@ parser.add_argument('--cleanup', choices=['scripts', 'all'], | |||
help='Select what to clean up after build') | |||
parser.add_argument('--requirements-file', '-r', | |||
help='Specify requirements.txt file') | |||
parser.add_argument('--pyproject-file', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase and update README.md
to include this option.
Added: error thorwn if both --requirements-file and --pyproject-file are present Added: readme entry for --pyproject-file Fixed: readme entry for --requirements-file now warns about mutual exclusivity with --pyproject-file
Hello, I've added suggested improvements to the original PR, hope @JakobDev reacts to this soon! |
pyproject.toml improvements
I forget about this PR. Sorry for that. @ENDrain Thanks, I have now merged your PR |
@TingPing can you give this an update please? |
This looks like a useful addition. Could you untangle the version history by removing the merges and rebase to current master? Does support recursive dependencies which use |
This PR adds support for reading dependencies from a ypproject.toml. On Python versions older than 3.11, you need to install tomli to use this feature.