Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rc file loading / local registry support + add tests #337

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor rc file loading / local registry support + add tests #337

wants to merge 2 commits into from

Commits on Jan 13, 2023

  1. node: Refactor rc file handling 

    - Use more "proper" package-manager-specific parsing, including what
  should be a fully-compliant (albiet over-engineered) parser for npm's
  ini format used in .npmrc.
- Moves all config loading into its own set of classes. (As it turns
  out, this *does* walk recursively, contrary to what I said before,
  oops!)
- Terminology change: rename rcfile -> config, just to match more with
  how npm describes itself.

Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
    @refi64
    refi64 committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    312dc8b View commit details
    Browse the repository at this point in the history

  2. node: Add tests for custom registries 

    This adds a test-time dependency on a running Verdaccio instance.

Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
    @refi64
    refi64 committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    b4ade5a View commit details
    Browse the repository at this point in the history