Update node-gyp installVersion #375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest version is 11, see https://github.com/nodejs/node-gyp/blob/main/package.json#L15 A lower version makes node-gyp remove the headers and force a new download
|
Could this cause problems for existing projects that worked w/ version |
|
I doubt it, because the changes seem to relevant to the Windows platform only, so they shouldn't affect flatpak builds on Linux at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version is 11, see https://github.com/nodejs/node-gyp/blob/main/package.json#L15
A lower version makes node-gyp remove the headers and force a new download
After a quick glance I think the changes for versions 10 and 11 affect the windows platform and error detection during tarball extraction so I think there's no other change required here.