dir: Ensure ~/.local/share/flatpak is 0700 #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This goes into a big old topic about Unix homedir permissions; it's not uncommon for general purpose OS vendors to have homedirs be 0755. In that case, applications need to ensure confidentiality for data requiring it (classically e.g. `~/.ssh`) by making the dirs `0700`. While most of the data in the flatpak per-user dir probably isn't confidential (debatably) we have a different issue; if container content includes suid or world-writable files/dirs, then having that data accessible to other users is obviously problematic. We're going to fix flatpak/ostree to not create files with those modes to begin with, but this simple fix closes off the attack route for the per-user directory. A different fix will be necessary for the system-wide repo. See: flatpak#837
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Jun 8, 2017
This is part of the saga of permissions and checkouts that came about thinking about flatpak, but suid and world-writable dirs are also an issue for us. There's no reason to make suid binaries accessible temporarily to users while we're computing a new root. Similarly, we don't want anyone to actually *write* to our temporary `/tmp`. The simple fix is to make an intermediate dir that's `0700`. See: ostreedev/ostree#909 See: flatpak/flatpak#843
rh-atomic-bot
pushed a commit
to coreos/rpm-ostree
that referenced
this pull request
Jun 8, 2017
This is part of the saga of permissions and checkouts that came about thinking about flatpak, but suid and world-writable dirs are also an issue for us. There's no reason to make suid binaries accessible temporarily to users while we're computing a new root. Similarly, we don't want anyone to actually *write* to our temporary `/tmp`. The simple fix is to make an intermediate dir that's `0700`. See: ostreedev/ostree#909 See: flatpak/flatpak#843 Closes: #821 Approved by: jlebon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes into a big old topic about Unix homedir permissions; it's not uncommon
for general purpose OS vendors to have homedirs be 0755. In that case,
applications need to ensure confidentiality for data requiring it (classically
e.g.
~/.ssh) by making the dirs0700.While most of the data in the flatpak per-user dir probably isn't confidential
(debatably) we have a different issue; if container content includes suid or
world-writable files/dirs, then having that data accessible to other users
is obviously problematic.
We're going to fix flatpak/ostree to not create files with those modes
to begin with, but this simple fix closes off the attack route for
the per-user directory.
A different fix will be necessary for the system-wide repo.
See: #837