libportal: Add activation-token to notification-action-invoked #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
activation-token
branch
2 times, most recently
from
f0d1471
to
a95458f
Compare
Use cleaner way to handle callback data in case one is provided, making it easier to handle if we need to chain more calls
3v1n0
force-pushed
the
activation-token
branch
4 times, most recently
from
5089d01
to
778f9ea
Compare
Since some time FDO Notifications introduced the ActivationToken signal to ensure that clients will receive an X11-startup notification ID or a wayland xdg-activation token in order to support stealing-focus prevention protocols. However this isn't supported by xdg-desktop-portal's. So fill the gap by adding a further activation token. While it could be added by as an optional parameter, it's just better to make it explicit. At the same time, let's bump the library version as the signal signature changed (while adding a new one with an extra parameter looked overkill.
Variant's can be null on signal emissions, nor can be the case here because we're getting it parsing a gvariant that will always include an empty array, in case.
|
@GeorgesStavracas have some time for this (and maybe the related portal one)? 😄 |
|
The user can now obtain an activation token since notification v2 is now merged. flatpak/xdg-desktop-portal#1298 I think this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some time FDO Notifications introduced the ActivationToken signal
to ensure that clients will receive an X11-startup notification ID or a
wayland xdg-activation token in order to support stealing-focus
prevention protocols.
However this isn't supported by xdg-desktop-portal's.
So fill the gap by adding a further activation token.
While it could be added by as an optional parameter, it's just better to
make it explicit.
At the same time, let's bump the library version as the signal signature
changed (while adding a new one with an extra parameter looked overkill.
Required by flatpak/xdg-desktop-portal#791