Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show odd errors when using remote URIs #823

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sergio-costas
Copy link

When a remote URI is selected in the portal, and the application
is inside a flatpak or a snap, it is not possible to get a local
path.

This MR detects this and shows an specific error, instead of the
odd errors that previously were shown.

@sergio-costas
Copy link
Author

This patch is the bare minimum for #820 and #213 . Ideally, apply #822 instead.

@barthalion barthalion force-pushed the fix_errors_with_remote_files branch from 908bac8 to a6ec469 Compare June 28, 2022 06:01
@sergio-costas sergio-costas force-pushed the fix_errors_with_remote_files branch from a6ec469 to 857c76d Compare June 28, 2022 07:44
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sergio-costas sergio-costas force-pushed the fix_errors_with_remote_files branch from 755a203 to 9331e01 Compare January 27, 2023 15:21
When a remote URI is selected in the portal, and the application
is inside a flatpak or a snap, it is not possible to get a local
path.

This MR detects this and shows an specific error, instead of the
odd errors that previously were shown.
@sergio-costas sergio-costas force-pushed the fix_errors_with_remote_files branch from 9331e01 to d70aada Compare January 30, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants