Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make unit tests quiet #145

Merged
merged 8 commits into from
May 30, 2024
Merged

make unit tests quiet #145

merged 8 commits into from
May 30, 2024

Conversation

flavorjones
Copy link
Owner

@flavorjones flavorjones commented May 30, 2024

The test suite has always been very noisy. This PR:

  • captures the logs of the test webrick server (instead of stdout)
  • captures the logs of the test recipes (instead of stdout)
  • wraps GPG errors up into the exceptions (instead of stderr)
  • uses the recipe logger in a few places that were doing raw puts
  • addresses a few minitest deprecation warnings
  • removes some debug messages left in the tests
  • shushes an uninitialized-ivar warnings on older rubies
  • moves test:unit rake task to Rake::TestTask

Thanks to @postmodern for pointing out how noisy the logs were where I had become immune to it.

@flavorjones flavorjones force-pushed the flavorjones-make-tests-quiet branch from d782771 to 8d1bab9 Compare May 30, 2024 02:36
@flavorjones flavorjones merged commit 250a0d5 into main May 30, 2024
34 checks passed
@flavorjones flavorjones deleted the flavorjones-make-tests-quiet branch May 30, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant