Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add toggle for disable automatic updates #173

Merged

Conversation

mofazhe
Copy link
Contributor

@mofazhe mofazhe commented Jul 4, 2024

feat(ui): add toggle for disable automatic updates

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 2a2bfb3
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/66869721818eab0008105f4f
😎 Deploy Preview https://deploy-preview-173--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

PR looks pretty good!

Minor non functional fixes:
image
Let's keep the code consistent here. Directly assign to the store state here, instead of assigning it the saved variable and then assigning it to state variable. Similar to how it's done in previous blocks of code.

image
Use single quotes instead of double quotes, so the failing test passes.

That should be all.

@mofazhe
Copy link
Contributor Author

mofazhe commented Jul 4, 2024

I committed the changes, please check again.

@flawiddsouza flawiddsouza merged commit 3eab940 into flawiddsouza:main Jul 4, 2024
6 checks passed
@mofazhe mofazhe deleted the feat/support-disable-auto-update branch July 4, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants