Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Settings > Add Global User Agent #195

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Conversation

kobenguyent
Copy link
Collaborator

Global User Agent

@kobenguyent kobenguyent added the UI label Jul 25, 2024
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit bff43be
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/66a214b5cb81f90008810b09
😎 Deploy Preview https://deploy-preview-195--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

It's best we don't provide this:
image
Your feature implementation is correct. That common examples part though helpful will have to be kept updated when browsers get updated. So let's not have it.

Instead let's mention that Restfox/vx.x.x will be used as the global user when the above input is empty.

@kobenguyent
Copy link
Collaborator Author

It's best we don't provide this: image Your feature implementation is correct. That common examples part though helpful will have to be kept updated when browsers get updated. So let's not have it.

Instead let's mention that Restfox/vx.x.x will be used as the global user when the above input is empty.

sure! I just thought providing a way to streamline the way user could use user agent. But yeah, updated as proposed.
Screenshot 2024-07-25 at 10 33 40

@flawiddsouza
Copy link
Owner

Remove the <p> tag around the note. As it's adding extra bottom margin. Also use <strong> instead of <b>, as <b> is deprecated even though it's widely available for use.
image
Source: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/b

@flawiddsouza flawiddsouza merged commit 6fb1225 into main Jul 25, 2024
6 checks passed
@flawiddsouza flawiddsouza deleted the feat-global-user-agent branch July 25, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants