Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Taiga #2033 | License): Fix Excavation Report #350

Merged
merged 7 commits into from
Jul 19, 2024

Conversation

StuCM
Copy link
Contributor

@StuCM StuCM commented Jul 19, 2024

Description

Issue with saving many excavation report tiles and freeze of page if report was uploaded without validated document name field.

Fixes

Changed cardinality to n
Made a custom version of the workflow-component-abstract
Added a disableAdd button which is passed to the loaded component
Created a custom component for the nodegroup for the report
Disable and enable the add button if the mandatory field is filled
This also fixes the edit button which was not working

Test

Reload the License model
coral reload
Navigate to the excavation report page
Try to add a report without the name, the add button should be disabled
Enter the name and the add button should be enabled
Add one report and save and continue
Return to the excavation report and the report should still be there
Add another report and save again
Return to see if the addtional report is shown
Hit edit and it should populate the fields
Check the instance to see if the tile is present
Check other many tile components such as location on the add heritage to see that this has not been affected by the change.

Note

There is a pr up on arches for fixing this issue but it focuses on validation at the backend, we will need to implement this at a later date which may change how this is implemented

archesproject/arches-her#1232

@taylorn01 taylorn01 merged commit 19340bf into dev Jul 19, 2024
4 of 5 checks passed
@andrea-kyurchiev andrea-kyurchiev deleted the fix/excavation-issues branch August 14, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants