-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add curatorial inspection workflow cypress test #446
Open
adamkelly03
wants to merge
43
commits into
dev
Choose a base branch
from
feature/add-curatorial-inspection-workflow-cypress-test
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/add curatorial inspection workflow cypress test #446
adamkelly03
wants to merge
43
commits into
dev
from
feature/add-curatorial-inspection-workflow-cypress-test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changes the url to the full localhost url. This is done so the tests can actually get to the point where they run as uncaught issues were otherwise blocking them before they even got started. We can debug this later
Ignores videos and screenshots generated from cypress studio
Also adds comments and sections off different tabs in the code
Also changes the url to the full localhost url. This is done so the tests can actually get to the point where they run as uncaught issues were otherwise blocking them before they even got started. We can debug this later
Ignores videos and screenshots generated from cypress studio
Also adds comments and sections off different tabs in the code
also renames tests to run in order
…l/coral-arches into feature/cypress-tests
also renames tests
… testFileForUpload.txt to try implementation for file upload
Similar to the other PRs, I've added orange in the spreadsheet to items that need attention. Rich textboxes are again untested |
cy.get('.widget-input-label').contains('Consultation ID'); | ||
cy.get('.widget-input').should('be.disabled'); | ||
|
||
cy.get('.workflow-nav-tab').contains('Asset Details').click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, there are better ways to determine if elements are disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress tests for Curatorial Inspection workflow.
Not covered Fully is the file upload and map tabs will have to potentially be manually tested as they have been quick tricky
Spreadsheet attached
https://docs.google.com/spreadsheets/d/1C1ctkKZdIIUjVUsPxAQOL-HQN3VMxsLEquoysLvVKBk/edit?hl=en_GB&pli=1&gid=1625375089#gid=1625375089
Flag for enforcement branch will need to merge 1st (Andreas)