Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(middleware): refactor SkipIfStillRunning to nooverlapping.New() #27

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

flc1125
Copy link
Owner

@flc1125 flc1125 commented Oct 27, 2024

closed: #18

@flc1125 flc1125 changed the title refactor(middleware): refactor SkipIfStillRunning to `nooverlapping… refactor(middleware): refactor SkipIfStillRunning to nooverlapping.New() Oct 27, 2024
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.52%. Comparing base (89fec4b) to head (5f9d88f).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x      #27      +/-   ##
==========================================
+ Coverage   96.38%   96.52%   +0.14%     
==========================================
  Files          11       12       +1     
  Lines         719      748      +29     
==========================================
+ Hits          693      722      +29     
  Misses         22       22              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flc1125 flc1125 marked this pull request as ready for review October 28, 2024 01:12
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Oct 28, 2024
@flc1125 flc1125 merged commit da81449 into 4.x Oct 28, 2024
17 checks passed
@flc1125 flc1125 deleted the middleware/nooverlapping branch October 28, 2024 01:13
@flc1125 flc1125 added this to the v4.0.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(middleware): migrate SkipIfStillRunning to the middleware directory
1 participant