-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update module github.com/fsnotify/fsnotify to v1.8.0 #88
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #88 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 10 10
Lines 688 688
=======================================
Hits 649 649
Misses 36 36
Partials 3 3 ☔ View full report in Codecov by Sentry. |
8c3ccca
to
bf69b5e
Compare
This PR contains the following updates:
v1.5.4
->v1.8.0
Release Notes
fsnotify/fsnotify (github.com/fsnotify/fsnotify)
v1.8.0
Compare Source
Additions
FSNOTIFY_DEBUG
to print debug logs to stderr (#619)Changes and fixes
windows: fix behaviour of
WatchList()
to be consistent with other platforms (#610)kqueue: ignore events with Ident=0 (#590)
kqueue: set O_CLOEXEC to prevent passing file descriptors to children (#617)
kqueue: emit events as "/path/dir/file" instead of "path/link/file" when watching a symlink (#625)
inotify: don't send event for IN_DELETE_SELF when also watching the parent (#620)
inotify: fix panic when calling Remove() in a goroutine (#650)
fen: allow watching subdirectories of watched directories (#621)
v1.7.0
Compare Source
This version of fsnotify needs Go 1.17.
Additions
illumos: add FEN backend to support illumos and Solaris. (#371)
all: add
NewBufferedWatcher()
to use a buffered channel, which can be useful in cases where you can't control the kernel buffer and receive a large number of events in bursts. (#550, #572)all: add
AddWith()
, which is identical toAdd()
but allows passing options. (#521)windows: allow setting the ReadDirectoryChangesW() buffer size with
fsnotify.WithBufferSize()
; the default of 64K is the highest value that works on all platforms and is enough for most purposes, but in some cases a highest buffer is needed. (#521)Changes and fixes
inotify: remove watcher if a watched path is renamed (#518)
After a rename the reported name wasn't updated, or even an empty string. Inotify doesn't provide any good facilities to update it, so just remove the watcher. This is already how it worked on kqueue and FEN.
On Windows this does work, and remains working.
windows: don't listen for file attribute changes (#520)
File attribute changes are sent as
FILE_ACTION_MODIFIED
by the Windows API, with no way to see if they're a file write or attribute change, so would show up as a fsnotify.Write event. This is never useful, and could result in many spurious Write events.windows: return
ErrEventOverflow
if the buffer is full (#525)Before it would merely return "short read", making it hard to detect this error.
kqueue: make sure events for all files are delivered properly when removing a watched directory (#526)
Previously they would get sent with
""
(empty string) or"."
as the path name.kqueue: don't emit spurious Create events for symbolic links (#524)
The link would get resolved but kqueue would "forget" it already saw the link itself, resulting on a Create for every Write event for the directory.
all: return
ErrClosed
onAdd()
when the watcher is closed (#516)other: add
Watcher.Errors
andWatcher.Events
to the no-opWatcher
inbackend_other.go
, making it easier to use on unsupported platforms such as WASM, AIX, etc. (#528)other: use the
backend_other.go
no-op if theappengine
build tag is set; Google AppEngine forbids usage of the unsafe package so the inotify backend won't compile there.v1.6.0
Compare Source
This version of fsnotify needs Go 1.16 (this was already the case since 1.5.1, but not documented). It also increases the minimum Linux version to 2.6.32.
Additions
all: add
Event.Has()
andOp.Has()
(#477)This makes checking events a lot easier; for example:
Becomes:
all: add cmd/fsnotify (#463)
A command-line utility for testing and some examples.
Changes and fixes
inotify: don't ignore events for files that don't exist (#260, #470)
Previously the inotify watcher would call
os.Lstat()
to check if a file still exists before emitting events.This was inconsistent with other platforms and resulted in inconsistent event reporting (e.g. when a file is quickly removed and re-created), and generally a source of confusion. It was added in 2013 to fix a memory leak that no longer exists.
all: return
ErrNonExistentWatch
whenRemove()
is called on a path that'snot watched (#460)
inotify: replace epoll() with non-blocking inotify (#434)
Non-blocking inotify was not generally available at the time this library was written in 2014, but now it is. As a result, the minimum Linux version is bumped from 2.6.27 to 2.6.32. This hugely simplifies the code and is faster.
kqueue: don't check for events every 100ms (#480)
The watcher would wake up every 100ms, even when there was nothing to do. Now it waits until there is something to do.
macos: retry opening files on EINTR (#475)
kqueue: skip unreadable files (#479)
kqueue requires a file descriptor for every file in a directory; this would fail if a file was unreadable by the current user. Now these files are simply skipped.
windows: fix renaming a watched directory if the parent is also watched (#370)
windows: increase buffer size from 4K to 64K (#485)
windows: close file handle on Remove() (#288)
kqueue: put pathname in the error if watching a file fails (#471)
inotify, windows: calling Close() more than once could race (#465)
kqueue: improve Close() performance (#233)
all: various documentation additions and clarifications.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.