Cancel animations on map controller move events

[Robbendebiene]

This fixes #946

Fling and double tap animations are already cancelled in multiple scenarios (like panning the map). This PR also cancels the animations whenever the MapController moves the camera. This is done to prevent interferences with animated camera moves.

[kengu]

@Robbendebiene - Can you fix the analyze issue?

[Robbendebiene]

@kengu Sorry, I've missed that. Now everything should be correctly formatted and annotated.

[Robbendebiene]

Can someone please review this?

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[Robbendebiene]

I still like to land this PR.

[b3nni97]

Can someone review this?

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[Robbendebiene]

@johnpryan or @kengu can you please review this.

[b3nni97]

Is this repository abandoned?

[ibrierley]

Sorry about all of the delay, there's a bit more action now. There's been some changes since, but if you can pull upstream when possible, then we'll see if we can get it tested and merged!

[JaffaKetchup]

@b3nni97 No! There have been some developments recently after a quiet period, hopefully it doesn't happen again.

[Robbendebiene]

@ibrierley and @JaffaKetchup I've just pulled upstream.

[JaffaKetchup]

Ok, thanks. Just needs to be reviewed before merge. I can't check it over for another 8 hours or so (I'm currently on mobile), but maybe another maintainer can!

[ibrierley]

Testing seems good. I note on the mapController page it now takes you to the correct location if mid fling and a different location selected, so happy with that.Thanks!

[ibrierley]

Happy to merge this, but not sure if you wanted to do any testing first @JaffaKetchup

[JaffaKetchup]

No it's ok, I trust your judgement. Please do merge! (If possible, use a Squash and Merge, but it doesn't matter too much)

[ibrierley]

Ah sorry missed your last comment.

[JaffaKetchup]

Nah no problem! It was only 2 commits anyway. I just prefer squashing for PRs with lots of commits: it keeps the main branch tidy.

[ibrierley]

Yep, makes sense.

[alanlanglois]

I made a custom move animation to center the map on current location when pressing a button.
When I pan and click the recenter button while the kinetic Pan animation is not finished, the recenter animation play as it should, but when finished it flick to what I guess is the end of the kinetic animation.

Is there a way to force stop the pan animation via the mapController or else?

[ibrierley]

are you using the latest version from Git (not the one from pub.dev ?)

[alanlanglois]

@ibrierley I'm using the one on pub.dev ( flutter_map: ^0.14.0 )

[ibrierley]

Ok, it may be worth trying the Git version for you then. I think that may have been fixed, but there could be circumstances where it isn't still (or I'm remembering wrong!).

[alanlanglois]

@ibrierley need to do more intensive tests, but looks like it fixies the bug!
When do you plan to land the next version including this fix?

[ibrierley]

We currently have no estimation, as it's a bit complicated, but something we are exploring.

…

On Mon, May 9, 2022 at 10:17 PM alan_langlois ***@***.***> wrote: @ibrierley <https://github.com/ibrierley> need to do more intensive tests, but looks like it fixies the bug! When do you plan to land the next version including this fix? — Reply to this email directly, view it on GitHub <#1043 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5YN5MIENRDIQBNCQUPQLTVJF6F5ANCNFSM5E7QEY5A> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[JaffaKetchup]

Please see #1188 for more information about publishing to pub.dev. As @ibrierley said, there is currently no estimate.