Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable stricter linter rules. #1238

Merged
merged 6 commits into from
May 15, 2022
Merged

Enable stricter linter rules. #1238

merged 6 commits into from
May 15, 2022

Commits on May 15, 2022

  1. Re-enable library_private_types_in_public_api

    @pablojimpas
    pablojimpas committed May 15, 2022
    Configuration menu
    Copy the full SHA
    e59f9bd View commit details
    Browse the repository at this point in the history

  2. Enable stricter linter rules. 

    Mostly trivial code changes made by running `dart fix --apply`

The rules enabled are:
  - `prefer_final_locals`: https://dart-lang.github.io/linter/lints/prefer_final_locals.html
  - `prefer_final_in_for_each`: https://dart-lang.github.io/linter/lints/prefer_final_in_for_each.html
  - `avoid_dynamic_calls`: https://dart-lang.github.io/linter/lints/avoid_dynamic_calls.html

All three rules take advantage of relatively recent improvements in the
Dart SDK and thus "modernize" the codebase, they can potentially have a
positive impact on performance as described in the reference links.
    @pablojimpas
    pablojimpas committed May 15, 2022
    Configuration menu
    Copy the full SHA
    c511573 View commit details
    Browse the repository at this point in the history

  3. Consistency in imports

    @pablojimpas
    pablojimpas committed May 15, 2022
    Configuration menu
    Copy the full SHA
    40b1619 View commit details
    Browse the repository at this point in the history

  4. Avoid weak typing and other common errors

    @pablojimpas
    pablojimpas committed May 15, 2022
    Configuration menu
    Copy the full SHA
    ddc99fe View commit details
    Browse the repository at this point in the history

  5. Prefer int literals and use named constants

    @pablojimpas
    pablojimpas committed May 15, 2022
    Configuration menu
    Copy the full SHA
    6c8b4a8 View commit details
    Browse the repository at this point in the history

  6. Update lib/src/gestures/gestures.dart 

    Co-authored-by: Luka S <github@jaffaketchup.dev>
    @pablojimpas @JaffaKetchup
    pablojimpas and JaffaKetchup authored May 15, 2022
    Configuration menu
    Copy the full SHA
    9209a6a View commit details
    Browse the repository at this point in the history