Added latLngToScreenPoint and refactored pointToLatLng #1330
Conversation
|
'due to issues' :D |
|
It fails on some lint stuff zzz :D, so leave for the moment, maybe something else hasn't copied over or something as well. |
|
hmm I don't really know what's happening, so not sure I trust any of this :D. Checks seem to fail on lints, but the line numbers it's referencing seem to be on old versions of files. Is it possible somehow lints use some caching ? |
|
Let me take a look, it might be 'my' new package scorer being annoying. |
|
The latest commit seems to have passed. |
|
ok curious, I keep getting an email saying its failed, but that's on my repo (thought they were normally done on fm), so maybe something else is confused somewhere on my side. If the test page all runs fine, and you can't spot any errors, then feel free to approve or merge. |
|
oh, maybe we want a minor version increase as well as the other version was released since ? |
There was a problem hiding this comment.
LGTM. We don't need a version change: I've got #1324 for that.
|
Interestingly, I can't see the checks passing here anymore, but I can see the green checkmark on your repo, so it should be OK. Just need to pay attention to that in the future. |
|
Super, thanks. |
Recreation of PR #1325 due to issues.