Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for flickering with fitbounds, moving calculations inside the lay… #1376

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

ibrierley
Copy link
Collaborator

Fix for flickering with fitbounds, moving calculations inside the layoutBuilder…

@ibrierley
Copy link
Collaborator Author

Possible fix for the flickering issue #1375. Note this PR will need to proper testing, as I don't experience the issue, so can't verify this properly.

I would also test things like reorientating the device, and on web and emulators as there may well be other issues introduced and this can be quite a fiddly one to fix.

@mohammedX6
Copy link

It's working fine for me

@JaffaKetchup
Copy link
Member

JaffaKetchup commented Oct 10, 2022

@ibrierley You happy for this to be merged?

@JaffaKetchup JaffaKetchup linked an issue Oct 10, 2022 that may be closed by this pull request
5 tasks
@ibrierley
Copy link
Collaborator Author

Yes, but as mentioned, I could never replicate the problem, so was hard to know if this has been properly tested. I think it would be good for someone else to test if they get the chance, otherwise just go for it.

@JaffaKetchup
Copy link
Member

Ok. @stx Can you also give this a test when you get a moment please?

@stx
Copy link

stx commented Oct 11, 2022

@JaffaKetchup Sure thing. I'll take a look at this tomorrow.

@stx
Copy link

stx commented Oct 13, 2022

@JaffaKetchup @ibrierley Sorry for the delay. Tested this on web and mobile and took 60 FPS captures and went through it frame by frame and it looks fixed and side-effect free! Nice work.

@JaffaKetchup JaffaKetchup self-requested a review October 14, 2022 06:07
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stx, no worries about the delay! LGTM.

@JaffaKetchup JaffaKetchup merged commit 4276a91 into fleaflet:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Using bounds creates map flicker
4 participants