-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Attributions #1390
Improve Attributions #1390
Conversation
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Superseded/continued/replaced by #1487. |
Note, I sometimes get
I'm currently testing the new v4 code, but I suspect this is more related to this (sorry a little out of touch atm)? Struggling to find a good method of reproducing it though... |
See #1379.
This PR adds a new attribution control,
RichAttributionWidget
as an alternative to the existingAttributionWidget
(which is still valid if you want a very minimal style) and has a more expressive API built aroundSourceAttribution
and its concrete subclasses.Possible discussion points:
TODOs:
Screenshot gallery: