Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyline stroke width in meters #1404

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Conversation

LeonTenorio
Copy link
Contributor

Implementation:

  • useStrokeWidthInMeter boolean parameter. When that value is true the PolylinePainter use the map to get the stroke width in meters and render using that.

@JaffaKetchup
Copy link
Member

@ibrierley @moonag @TesteurManiak What do we think about this being in core? It makes sense to me, and I think using Distance() is accurate - at least it has been accurate enough when I've done this same thing before.

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@JaffaKetchup JaffaKetchup self-requested a review December 21, 2022 12:30
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this is a very useful feature :)

@JaffaKetchup JaffaKetchup merged commit eaecd23 into fleaflet:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants