-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent double scrolling #1453
Prevent double scrolling #1453
Conversation
Before this change the PointerScrollEvent handler was not registered with PointerSignalResolver which meant that if scrolling was enabled for FlutterMap and it was within a scrollable widget or had a scrollable child widget then they would both be scrolled simultaneously. This is only noticeable on web since on mobile a drag gesture is used to scroll/pan instead of mouse scrolling.
Thanks @rorystephenson, we'll try to have a look at this soon! |
The code looks good to me, do you think you can add an example page that would showcase your changes and help us to test them ? |
@TesteurManiak You can test this with the "Map inside ListView" example in web by scrolling with the mouse over the map inside the ListView. Without these changes the map and the ListView will both react to the scrolling. With these changes only the map will react (by zooming). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been able to test the example you've mentioned @rorystephenson thanks 👍
I wasn't able to find any regression in the other scrolling behavior so everything is good for me (you can double check if you want @JaffaKetchup)
Hello, do you know when this will be released ? |
Hi @jbournonville, |
Before this change the
PointerScrollEvent
handler was not registered withPointerSignalResolver
which meant that if scrolling was enabled forFlutterMap
and it was within a scrollable widget or had a scrollable child widget then they would both be scrolled simultaneously. This is only noticeable on web since on mobile a drag gesture is used to scroll/pan instead of mouse scrolling.