Improve Marker.anchor performance
#1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorystephenson
force-pushed
the
restore-marker-anchor
branch
from
4ebd516
to
2992baa
Compare
This allows Marker to accept the same anchor argument as MarkerLayer, anchorPos, whilst still precalculating the Anchor so it isn't calculated on every build. Co-authored-by: Luka S <github@jaffaketchup.dev>
rorystephenson
force-pushed
the
restore-marker-anchor
branch
from
2992baa
to
5400887
Compare
JaffaKetchup
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1552, it re-instates the precalculated Anchor on a Marker whilst leaving the argument as an anchorPos which makes it consistent with the MarkerLayer options.