Support desktop (click and drag) rotation #1592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1568.
Thanks to @TesteurManiak for the infrastructure implementation and POC and @ibrierley for the rotation algorithm itself. Also thanks to https://stackoverflow.com/questions/48916517/javascript-click-and-drag-to-rotate and https://github.com/openlayers/openlayers/blob/7099f14bd2348491c1550f7b0be929e5da00d83d/src/ol/interaction/DragRotate.js#L65.
Still to do before this can be release ready:
Add(redundant with 'Allow for other keyboard triggers')InteractiveFlag.cursorRotate
Consider renaming(InteractiveFlag.rotate
for clarityInteractiveFlag.cursorRotate
will not be added)Allow for customizing rotation degree scale (1 by default)(does not work correctly and can cause rotation jumps)Also moved
InteractionOptions.enableScrollWheel
toInteractiveFlags.scrollWheelZoom
with deprecation.