Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code clean up, additional lints #1594

Merged
merged 19 commits into from
Aug 3, 2023
Merged

Code clean up, additional lints #1594

merged 19 commits into from
Aug 3, 2023

Commits on Jul 20, 2023

  1. add lints, code style improvements, add assert messages

    @josxha
    josxha committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    309b6b4 View commit details
    Browse the repository at this point in the history

  2. use documentation comments for methods 

    https://dart.dev/language/comments#documentation-comments
    @josxha
    josxha committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    98e38d6 View commit details
    Browse the repository at this point in the history

  3. better callback parameter names, dart format

    @josxha
    josxha committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    21bb043 View commit details
    Browse the repository at this point in the history

  4. fix lazy fields in MapCamera

    @josxha
    josxha committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    2d8b483 View commit details
    Browse the repository at this point in the history

  5. use documentation comments part 2

    @josxha
    josxha committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    1d896eb View commit details
    Browse the repository at this point in the history

  6. use @immutable for immutables, const constructors where possible

    @josxha
    josxha committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    38d7250 View commit details
    Browse the repository at this point in the history

  7. refactor loops

    @josxha
    josxha committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    9d300df View commit details
    Browse the repository at this point in the history

  8. use math min() / max()

    @josxha
    josxha committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    df4b205 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. remove omit_local_variable_types lint

    @josxha
    josxha committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    6bd5244 View commit details
    Browse the repository at this point in the history

  2. use full method bodies instead of =>

    @josxha
    josxha committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    aec5a3d View commit details
    Browse the repository at this point in the history

  3. typo

    @josxha
    josxha committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    82b3914 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Merge branch 'master' into code-style

    @JaffaKetchup
    JaffaKetchup authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    9468907 View commit details
    Browse the repository at this point in the history

  2. Fixed conflict resolution bugs

    @JaffaKetchup
    JaffaKetchup committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c05596e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Merge branch 'master' into code-style

    @JaffaKetchup
    JaffaKetchup authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    eebf235 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Merge branch 'master' into code-style

    @JaffaKetchup
    JaffaKetchup authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    e321dfc View commit details
    Browse the repository at this point in the history

  2. Fix lint warning

    @JaffaKetchup
    JaffaKetchup committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a50be82 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. remove cupertino imports 

    fix
https://github.com/fleaflet/flutter_map/pull/1594/files/a50be82dfbfc92fff753c7b704d4b98bb63a6d81#r1275362713
https://github.com/fleaflet/flutter_map/pull/1594/files/a50be82dfbfc92fff753c7b704d4b98bb63a6d81#r1275360404
    @josxha
    josxha committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    5487e86 View commit details
    Browse the repository at this point in the history

  2. remove non null cast

    @josxha
    josxha committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ca24bac View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. revert list mapping 

    https://github.com/fleaflet/flutter_map/pull/1594/files/38d7250da5524779449cab91559d1b25234641da..df4b2053e79c71704b02fd72dcfe52bfd28d6888#r1270268326
    @josxha
    josxha committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    f73cb9c View commit details
    Browse the repository at this point in the history