-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleMarker
Performance Optimizations
#1679
Conversation
CustomPainter
for all CircleMarker
s
Hi @Alexays, thanks for your PR! We'll have a look into this, as performance improvements are always welcome. However, the tests are now failing. |
Thanks! |
Just pushed another improvement. |
Wow that's an improvement and a half! I'll check later today. To be honest, circle markers have not had much work done to them since their introduction. |
Thanks for the contribution! Do you think you can also update the |
(maybe follow the pattern from Many Markers?) |
Sure done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've tested the example on Flutter Web with canvaskit and the map was quite smooth even with 20.000 circles 👍
CustomPainter
for all CircleMarker
sCircleMarker
Performance Optimizations
Many thanks :) |
I'm working on a project that requires a map with a lot of elements, while maintaining optimum performance.
At the moment, we have one custom painter per circle, which leads to a huge drop in performance when there are thousands of circles, for example, whereas we could just as easily use a single painter.