Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CircleMarker's incorrect appearance and size #1692

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

Alexays
Copy link
Contributor

@Alexays Alexays commented Oct 18, 2023

Fix #1688

  • Radius instead of diameters
  • Fixed circles with only borders/filled with a transparent color

@Alexays Alexays changed the title fix: radius and opacity fix(CircleLayer): radius and opacity Oct 18, 2023
@JaffaKetchup
Copy link
Member

Thanks for getting on this so quickly :)
I'll have a look into it ASAP.

Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't quite look like a circle to me 😂! Did you forget something or is this not ready for review yet?

image

@Alexays
Copy link
Contributor Author

Alexays commented Oct 18, 2023

Oups sorry, fixed! @JaffaKetchup

@JaffaKetchup JaffaKetchup self-requested a review October 18, 2023 21:12
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this so quickly, we really do appreciate it!

I added an extra circle marker for testing as well. Dorney Lake is pretty much exactly 2.2km long, so it's useful to test radii and such like.

@JaffaKetchup JaffaKetchup changed the title fix(CircleLayer): radius and opacity Fixed CircleMarker's incorrect appearance and size Oct 18, 2023
@JaffaKetchup JaffaKetchup merged commit 117f254 into fleaflet:master Oct 18, 2023
6 checks passed
@algizmonaco
Copy link

algizmonaco commented Nov 3, 2023

Hi

just tried the demo and the circle still does not fill correctly. When zooming it works partially.

Regards Daniel

Simulator Screenshot - iPhone 14 Pro Max - 2023-11-03 at 10 45 56

Simulator Screenshot - iPhone 14 Pro Max - 2023-11-03 at 10 53 41

@JaffaKetchup
Copy link
Member

Hi @algizmonaco,
I see you're running on iOS, can you try disabling Impeller to see if that resolves the issue?

@algizmonaco
Copy link

thx,

Disabling Impeller fixes the issue. keeping disabled until it is fixed. May you want to add this to readme. thx

Daniel

@JaffaKetchup
Copy link
Member

I believe the fix is already available on Flutter's 'master' branch, so hopefully it won't take too long to arrive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CircleMarker incorrectly fills with stroke color and has incorrect size
3 participants