fix: MapPosition.hashCode value distribution
#1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josxha
requested review from
ibrierley,
mootw,
TesteurManiak and
JaffaKetchup
TesteurManiak
approved these changes
Dec 2, 2023
JaffaKetchup
approved these changes
Dec 2, 2023
JaffaKetchup
changed the title
hashCode value distributionMapPosition.hashCode value distribution
JaffaKetchup
removed
the
bug
josxha
added a commit
that referenced
this pull request
Dec 2, 2023
josxha
added a commit
that referenced
this pull request
Dec 6, 2023
commit ec81782 Author: Luka S <github@jaffaketchup.dev> Date: Sat Dec 2 20:48:08 2023 +0000 chore: v6.1.0 release preparation (#1749) commit df40d8c Author: mootw <spencer@xqkz.net> Date: Sat Dec 2 10:49:29 2023 -0600 perf: avoid caching a single multiplication (#1743) commit ad8318b Author: Joscha <34318751+josxha@users.noreply.github.com> Date: Sat Dec 2 16:39:21 2023 +0100 refactor: example app plugins (#1744) commit c0829b4 Author: Joscha <34318751+josxha@users.noreply.github.com> Date: Sat Dec 2 16:31:38 2023 +0100 fix: `MapPosition.hashCode` value distribution (#1747) commit 51d3eda Author: Luka S <github@jaffaketchup.dev> Date: Sat Dec 2 11:34:13 2023 +0000 revert: #1731 (#1745) Revert #1731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a better value distribution of for
MapPosition.hashCode.Old
Adding the 3 hashCodes together has the effekt that relativly bigger values are more likely to happen. This increases the chance of hash code collision.
New
If we use
.hashCodeanyway let's do the following change:Can and should get cherry picked to
v6.1.0-rc