Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tests): import root library where possible #1807

Merged
merged 2 commits into from
Jan 22, 2024
Merged

refactor(tests): import root library where possible #1807

merged 2 commits into from
Jan 22, 2024

Conversation

josxha
Copy link
Contributor

@josxha josxha commented Jan 21, 2024

  • Decreases the amount of individual imports
  • Decreases the amount of lines changed in the future

@josxha josxha added this to the v7.0 milestone Jan 21, 2024
@josxha josxha self-assigned this Jan 21, 2024
JaffaKetchup
JaffaKetchup approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Untested, but shouldn't make a difference.

@JaffaKetchup JaffaKetchup changed the title refactor(tests): use library import where possible refactor(tests): import root library instead of 'src/' where possible Jan 22, 2024
@JaffaKetchup JaffaKetchup changed the title refactor(tests): import root library instead of 'src/' where possible refactor(tests): import root library where possible Jan 22, 2024
@JaffaKetchup JaffaKetchup merged commit 0f5342f into fleaflet:master Jan 22, 2024
6 checks passed
@josxha josxha deleted the refactor-imports branch January 23, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaffaKetchup JaffaKetchup JaffaKetchup approved these changes

Assignees

@josxha josxha

Labels
None yet
Projects
Development
Archived in project
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@josxha @JaffaKetchup