Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make FlutterMap.options an optional parameter #1816

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

josxha
Copy link
Contributor

@josxha josxha commented Feb 1, 2024

This is a really tiny change but a huge quality of life change - at least for me. 😅

@josxha josxha added this to the v7.0 milestone Feb 1, 2024
@josxha josxha self-assigned this Feb 1, 2024
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we may want to consider whether the current default values are useful. Thanks!

@JaffaKetchup JaffaKetchup merged commit f0c684a into fleaflet:master Feb 3, 2024
7 checks passed
@josxha josxha deleted the optional-MapOptions branch February 3, 2024 17:44
@VittorioParagallo
Copy link

I'm not sure it depends from this, with versions 7 i got an assertion exception "flutter map 'newOptions != value.options': Should not update options unless they change"
This happens when:

  • i show a map
  • open a dialog
  • i close the dialog and the error pop up.
    reverted on v6.1, no more troubles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants