refactor!: make LatLngBounds mutable & depend less on 'latlong2'
#1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josxha
requested review from
JaffaKetchup,
ibrierley,
mootw and
TesteurManiak
JaffaKetchup
requested changes
Mar 10, 2024
|
Ready for another review. I think this pull request is now non-breaking. |
JaffaKetchup
approved these changes
Mar 12, 2024
JaffaKetchup
changed the title
LatLngBoundsLatLngBounds mutable & depend less on 'latlong2'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is probably a bit controversial.
LatLngBounds.fromCorners()and adds a new default raw constructor for better performance. Even though values get provided directly it uses asserts to catch potential implementation errors.Very similar would be Bounds if I'm not mistaken.